Max of a List, STUMPED

When I ran it, obvList was empty.

There's an issue with your IF condition that's causing the program to check obvList before your windows were ready.

Replace this: 

if not self.priceWindow.IsReady and self.obvWindow.IsReady: return

With this:

if not (self.priceWindow.IsReady and self.obvWindow.IsReady) : return

Hi Nicholas Fitzgerald,
Thank you .ekz. for your response.
Alternatively, instead of using the list and max() method, we can use the IndicatorExtensionsOf and the maximum indicator; this will reduce the overall runtime and align the algorithm with the best practices
 

# in Initialize
self.obvMax = IndicatorExtensions.Of(Maximum(12),self.obv)

and whenever we want to get the max value we need to use:
 

if self.obvMax.IsReady:
	#to get the max : self.obvMax.Current.Value

Best,
Varad Kabade

Hi Ekz and Varad,

Ekz that did indeed fix my issue, thank you!

For your solution Varad, just setting up the indicators in this way allow me to slice the data though? I need to retrieve the max value excluding the most recent price?

Regards,

Nick

Hi Nicholas,
To exclude the latest entry we just need to add the following:
 

self.obvMax = IndicatorExtensions.Of(Delay(1), self.obvmax )

after the following inside Initialize:
 

self.obvmax = IndicatorExtensions.Of(Maximum(12),self.obv)

Note that all the indicators were created using IndicatorExtensions.Of will be automatically updated when we update self.obv. We have created an example algorithm showing the use of the above features.
Best,
Varad Kabade